More fixes for Unicode support#90
Merged
Merged
Conversation
fea836f to
c722387
Compare
c722387 to
840113d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because Unicode support is hard, here's another PR. It also helps to understand how PHP handles UTF-8. All PREG-related functions in PHP will calculate string offsets in bytes and not character lengths; this causes problems because
mb_*functions use character lengths.This also means #88 will need to be reevaluated whenever I get a chance.
Reported in westonruter/syntax-highlighting-code-block#400
/cc @westonruter