Skip to content

Fix UTF-8 in PHP in function parameters#88

Closed
allejo wants to merge 2 commits into
9.18from
fix/utf8-fxn-calls
Closed

Fix UTF-8 in PHP in function parameters#88
allejo wants to merge 2 commits into
9.18from
fix/utf8-fxn-calls

Conversation

@allejo

@allejo allejo commented May 16, 2021

Copy link
Copy Markdown
Collaborator

See #87


&lt;div <span class="hljs-class"><span class="hljs-keyword">class</span>="<span class="hljs-title">form</span>-<span class="hljs-title">group</span>"&gt;
&lt;<span class="hljs-title">div</span> <span class="hljs-title">class</span>="<span class="hljs-title">col</span>-<span class="hljs-title">lg</span>-<span class="hljs-title">offset</span>-1 <span class="hljs-title">col</span>-<span class="hljs-title">lg</span>-11"&gt;
&lt;?= <span class="hljs-title">Html</span>::<span class="hljs-title">submitButton</span>('<span class="hljs-title">Вход</span>', ['<span class="hljs-title">class</span>' =&gt; '<span class="hljs-title">btn</span> <span class="hljs-title">btn</span>-<span class="hljs-title">primary</span>']) ?&gt;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not <span class="hljs-string">'Вход'</span>?
'<span class="hljs-title">btn</span> <span class="hljs-title">btn</span>-<span class="hljs-title">primary</span>' too look strange

@WinterSilence

Copy link
Copy Markdown

@joshgoebel

joshgoebel commented May 16, 2021

Copy link
Copy Markdown

Note: Highlight.php is NOT Highlight.js and may not behave at all the same since it's using a port of a much older version.

@WinterSilence

Copy link
Copy Markdown

@joshgoebel yes, captain Obvious!

@MX-Qulin

MX-Qulin commented May 30, 2021 via email

Copy link
Copy Markdown

@allejo

allejo commented Jul 9, 2021

Copy link
Copy Markdown
Collaborator Author

Closing because now it's irrelevant; see #87 (comment)

@allejo allejo closed this Jul 9, 2021
@allejo allejo deleted the fix/utf8-fxn-calls branch July 9, 2021 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants