Fix ScriptRange Add when IList has a fixed size #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could you add a small test to capture this use case and any future regressions? |
Contributor
Author
|
The Test "A400_builtins" already tests the array.add function and it fails without this patch if the test application is run under .net9. I don't know what other tests i should write. |
…a new ScripArray if the list is of a fixed size
dfc3745 to
535c541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With .NET9 casting the _values to an IList no longer results in a null value. This casts to an fixed size IList.
This results in an "Collection was of a fixed size" when trying to add a new item
When the list has a fixed size it will be recreated as a ScriptArray to fixed this, this fixes #585.