Skip to content

fix(updates): unblock restart to apply update on macOS#3984

Merged
louis030195 merged 1 commit into
screenpipe:mainfrom
Anshgrover23:fix/update-app-broekn
Jun 10, 2026
Merged

fix(updates): unblock restart to apply update on macOS#3984
louis030195 merged 1 commit into
screenpipe:mainfrom
Anshgrover23:fix/update-app-broekn

Conversation

@Anshgrover23

Copy link
Copy Markdown
Contributor

Description:

Fixes #3973

  • macOS user report (2026-06-10): clicking "restart to apply update" hangs on "restarting…", requires manual tray Quit, then
    app relaunches into a stuck "Screenpipe is still starting" screen.
  • Root cause: relaunch() fires ExitRequested, which main.rs blocks via prevent_exit() unless QUIT_REQUESTED=true.
    Banner click never set the flag, so the exit was silently cancelled. Linux had the same bug; Windows didn't (NSIS installer calls
    process::exit directly).

Fix

  • New restart_for_update Tauri command mirrors the auto-update path: gate → stop_screenpipe()QUIT_REQUESTED=true
    app.restart() off-thread.
  • update-banner.tsx routes macOS/Linux through the new command. Windows path unchanged.

@louis030195 louis030195 merged commit 910d4cb into screenpipe:main Jun 10, 2026
8 of 12 checks passed
louis030195 pushed a commit that referenced this pull request Jun 10, 2026
regenerated specta bindings — restart_for_update was added to updates.rs
in #3984 but lib/utils/tauri.ts was not regenerated, breaking typecheck
and tauri build:

  components/update-banner.tsx(139,36): error TS2339:
  Property 'restartForUpdate' does not exist on type ...

ran: bun run bindings:generate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] macOS: "Restart to apply update" doesn't apply the update, app stuck on "Screenpipe is still starting"

2 participants