fix: honor "pipe notifications" toggle on /notify route#3880
Merged
louis030195 merged 1 commit intoJun 6, 2026
Merged
Conversation
POST /notify previously ignored notificationPrefs.pipeNotifications and always showed the SwiftUI panel + wrote to history. Now mirrors the display-change path in monitor_events.rs: reads the setting from SettingsStore, fails open on missing/parse errors, and when the toggle is off + type=pipe, logs 'notify: skipped (pipe notifications disabled)' and returns 200 without showing or persisting. Type=system and other upstream-gated paths pass through unchanged. Includes 6 unit tests covering the gate semantics.
louis030195
reviewed
Jun 6, 2026
louis030195
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, clean fix
generated by the screenpipe pr-review pipe (https://screenpi.pe), not written by a human — reply and tag @louis030195 if it got something wrong.
Contributor
Author
|
@louis030195 Can I get a review on this one ? |
louis030195
pushed a commit
that referenced
this pull request
Jun 6, 2026
…ate skips it #3880 gates type:"pipe" notifications behind notificationPrefs.pipeNotifications. The auto-update "what's new" toast POSTed to /notify with no type, which the route defaults to "pipe" — so it would be wrongly suppressed when a user turns off Pipe notifications, even though app updates have their own appUpdates toggle. Tag it "app-update" to keep the two classes decoupled. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #3879
Screen.Recording.2026-06-06.at.6.25.21.PM.mov
Screen.Recording.2026-06-06.at.6.17.07.PM.mov
The
Pipe notificationstoggle in Settings → Notifications was ignored — pipes POSTing tolocalhost:11435/notifyalways showed the native panel; this PR gates the/notifyroute onnotificationPrefs.pipeNotifications(matching the display-change path), so turning the toggle off now actually suppresses pipe alerts.