feat(app): surface installed-but-uncaptured apps in privacy filters#3866
Merged
Conversation
The Ignored/Included app filters only autocompleted apps that already had frames in the DB, so you couldn't add a rule for an app until it had been recorded at least once. Now installed apps that have no captures yet are merged into the filter options (and the browse picker), each with its real app icon and an "installed · not captured yet" hint. - icons.rs: list_installed_apps() per OS (macOS /Applications scan, Windows Start Menu .lnk, Linux .desktop), read-only and best-effort. - server.rs: cached GET /installed-apps on the tauri app server, next to /app-icon (same host that already resolves icons by name). - useInstalledApps() hook + merge in createWindowOptions and WindowPicker. - e2e: privacy-installed-apps.spec.ts mocks the endpoint and asserts an uncaptured app shows up with the not-captured treatment. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
Author
e2e: passing ✅Ran the new spec against a fresh The spec mocks |
louis030195
pushed a commit
that referenced
this pull request
Jun 5, 2026
The "Generate E2E Coverage Report" step validates that every *.spec.ts in e2e/specs has an entry in coverage-map.json. Two recently-added specs were missing entries, so the step failed once the test run itself started passing: - privacy-installed-apps.spec.ts (PR #3866) - zz-app-entitlement-gate.spec.ts (PR #3846) Add manifest entries for both and regenerate COVERAGE.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The privacy app filters (Ignored Apps / Included Apps) only autocompleted apps that already had frames in the database, so you couldn't add a rule for an app until it had been recorded at least once. That's backwards for the common privacy case: you want to block an app (a password manager, a banking app) before it is ever captured, not after.
This merges installed applications that have no captures yet into the filter options (and the browse picker), each with its real app icon and an "installed · not captured yet" hint. The icon already resolves by name through the existing
/app-iconhost, so an uncaptured app still renders with its real icon.(Mockup of the dropdown. App names are generic product examples, no real user data.)
How
Backend (tauri app server, the same host that already serves
/app-icon):icons.rs:list_installed_apps()per OS. macOS scans the standard/Applicationsdirectories, Windows scans Start Menu.lnkshortcuts, Linux parses.desktopName=entries. Read only, best effort, returns an empty list on any failure.server.rs: cachedGET /installed-apps(60s server side) returning the deduped, sorted name list.Frontend:
use-installed-apps.tsx: small hook that fetches the list. Degrades to captured-only behavior if the route is missing (older backend) or unreachable, so nothing breaks.privacy-section.tsx: merges installed-but-uncaptured apps intocreateWindowOptionsfor both the Ignored and Included filters (deduped against captured apps).window-picker.tsx: surfaces the same apps as app-only rows in the browse dialog.Testing
bun run buildpasses (types valid, static export clean).privacy-installed-apps.spec.tsmocks/installed-appsand asserts an uncaptured app shows up as a typeable option carrying the not-captured treatment. I'm running it locally against a fresh--features e2edebug build and will post the result in a comment. It also runs in CI.Notes
/installed-appson 11435, next to/app-icon. Nothing changes for users who never open privacy settings.🤖 Generated with Claude Code