Skip to content

Master#40

Merged
scravy merged 1 commit intoscravy:masterfrom
Alexander-Taran:master
Jun 23, 2022
Merged

Master#40
scravy merged 1 commit intoscravy:masterfrom
Alexander-Taran:master

Conversation

@Alexander-Taran
Copy link
Copy Markdown
Contributor

@Alexander-Taran Alexander-Taran commented Jun 21, 2022

fix for node 18
resolves #39
tests are passing

@scravy
Copy link
Copy Markdown
Owner

scravy commented Jun 23, 2022

Thank you for the fix.

@scravy scravy merged commit 1722be3 into scravy:master Jun 23, 2022
@Pwndrian
Copy link
Copy Markdown

Pwndrian commented Aug 7, 2023

FYI: The change from string to number was reverted by the Node.js team in Node.js 18.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Throws on node 18

4 participants