Fix: 'Week' and 'Sunday' problem in ID locale#399
Closed
feryandi wants to merge 2 commits intoscrapinghub:masterfrom
Closed
Fix: 'Week' and 'Sunday' problem in ID locale#399feryandi wants to merge 2 commits intoscrapinghub:masterfrom
feryandi wants to merge 2 commits intoscrapinghub:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
=======================================
Coverage 94.95% 94.95%
=======================================
Files 302 302
Lines 2436 2436
=======================================
Hits 2313 2313
Misses 123 123
Continue to review full report at Codecov.
|
Contributor
|
I see a problem with these changes: you are editing a JSON file that comes from Unicode CLDR data (see https://dateparser.readthedocs.io/en/latest/contributing.html#guidelines-for-editing-translation-data). Those files are not meant to be modified manually, only updated from Unicode CLDR data. |
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new rule for 'week' and remove existing 'week' translation from Indonesia (id)
This should fix #398
Translation removed:
week:minggureason: in Indonesia language,
mingguas standalone word is more likely to be translated intosundayRule added:
reason: to mitigate the missing translation of week, I've hard-coded the most probable sentence which the word
minggutranslated asweek