possible fix of 'ago' problem in Russian#340
possible fix of 'ago' problem in Russian#340eszakharova wants to merge 1 commit intoscrapinghub:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
==========================================
+ Coverage 97.61% 97.61% +<.01%
==========================================
Files 20 20
Lines 1674 1677 +3
==========================================
+ Hits 1634 1637 +3
Misses 40 40
Continue to review full report at Codecov.
|
|
The reason behind this is that he Your approach is not good because we can't hardcode that regex there and would have side effects for other languages. However, the issue is still valid. We could probably add a regex into the ru.yaml file. Maybe a simplification as |
'2000 год' in Russian is 'year 2000'
Before was parsed as '2000 years ago'
After