Workaround for zipimporter not having exec_module before Python 3.10#1069
Merged
Gallaecio merged 1 commit intoscrapinghub:masterfrom Dec 9, 2022
Merged
Workaround for zipimporter not having exec_module before Python 3.10#1069Gallaecio merged 1 commit intoscrapinghub:masterfrom
Gallaecio merged 1 commit intoscrapinghub:masterfrom
Conversation
georgevreilly
commented
Aug 24, 2022
| else: | ||
| # This can happen before Python 3.10 | ||
| # if spec.loader is a zipimporter and the Python runtime is in a zipfile | ||
| code = spec.loader.get_code(module.__name__) |
Contributor
Author
There was a problem hiding this comment.
This, in essence, is what loader.exec_module does.
|
@serhii73, can I get this reviewed and merged, please? |
serhii73
approved these changes
Dec 8, 2022
Gallaecio
approved these changes
Dec 9, 2022
Contributor
Gallaecio
left a comment
There was a problem hiding this comment.
Looks good to me, though I wonder if we should go with a try-except approach instead.
wRAR
approved these changes
Dec 9, 2022
serhii73
pushed a commit
that referenced
this pull request
Dec 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #849
Tested with Python 3.8 and 3.9