Merged
Conversation
ef87155 to
6d596ed
Compare
This makes scoverage work with incremental compilation. Instead of starting from scratch we reuse the data in `scoverage.coverage` for files that are not being compiled in this compilation unit (because zinc skipped them). We read the existing `scoverage.coverage` and merge it with the new one being generated. We make sure that statement ids by starting from the max id in the existing coverage. This PR also refactors the test code a little bit to be able to test for incremental compilation.
6d596ed to
cd5926c
Compare
lolgab
added a commit
to lolgab/sbt-scoverage
that referenced
this pull request
Dec 15, 2025
This is useful together with scoverage/scalac-scoverage-plugin#742
tgodzik
approved these changes
Dec 15, 2025
Contributor
tgodzik
left a comment
There was a problem hiding this comment.
Looks good! Thanks for contributing.
Contributor
|
Do you need a release for the sbt plugin or do you want to test some things still? |
Contributor
Author
Let me test one thing first. |
Contributor
Author
|
I'm done with my tests |
Contributor
|
The release is out! |
tgodzik
pushed a commit
to scala/scala3
that referenced
this pull request
Dec 22, 2025
tgodzik
added a commit
to scala/scala3-lts
that referenced
this pull request
Jan 22, 2026
Port of scoverage/scalac-scoverage-plugin#742 for Scala 3. [Cherry-picked 32a6ea6][modified]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #492
This makes scoverage work with incremental compilation. Instead of starting from scratch we reuse the data in
scoverage.coveragefor files that are not being compiled in this compilation unit (because zinc skipped them).We read the existing
scoverage.coverageand merge it with the new one being generated.We make sure that statement ids by starting from the max id in the existing coverage.
This PR also refactors the test code a little bit to be able to test for incremental compilation.