BUG: Support sparse arrays in scipy.sparse.csgraph.laplacian#19156
BUG: Support sparse arrays in scipy.sparse.csgraph.laplacian#19156perimosocordiae merged 2 commits intoscipy:mainfrom
Conversation
dschult
left a comment
There was a problem hiding this comment.
For what it is worth, this looks good to me. :)
|
Thanks for the PR! While we're here, could you add a unit test that exercises the bug? |
I need help with adding a test. I know where to add it - @pytest.mark.parametrize("arr_type", [np.array,
sparse.csr_matrix,
sparse.coo_matrix]) |
|
The |
perimosocordiae
left a comment
There was a problem hiding this comment.
Changes look good, and thanks for adding the extra test cases. LGTM
dschult
left a comment
There was a problem hiding this comment.
Looks good to me too.
Thanks!
|
What additional steps should be taken to get it merged or backport it to another version? |
|
Merged. Thanks! |
…9156) * BUG: Support sparse arrays in scipy.sparse.csgraph.laplacian * TST: Added unit test for laplacian
Reference issue
Fixes #19149
What does this implement/fix?
Resolves
AttributeErrorraised on sparse arrays inscipy.sparse.csgraph.laplacian(See #19149)Additional information
This resolves/unblocks test coverage in scikit-learn/scikit-learn#27161
Tagging @perimosocordiae for review, as he reviewed the original issue