MAINT: Upload nightlies with dev0 to keep the pin stable downstream #3652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
reviewed
Feb 10, 2025
Member
There was a problem hiding this comment.
Is this enough? The version is also stored in the METADATA file inside the wheel. So if you don't update that, does the resolve get into trouble?
Member
Author
There was a problem hiding this comment.
I want to say yes, as the problem is just the version number in the pin in nightly.txt and we aren't comparing 2 scipp dev wheels, pip installs the wheel just fine too.
MridulS
added a commit
to MridulS/scipp
that referenced
this pull request
Feb 11, 2025
…nstream (scipp#3652)" This reverts commit 7dd1480.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.