Expose values and variances properties as numpy.ndarray-like objects #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ea51a0 to
350c56a
Compare
OwenArnold
reviewed
Jun 17, 2019
Contributor
OwenArnold
left a comment
There was a problem hiding this comment.
Brief look at the tests - looks good. To obtain historical behaviour users can always result.flatten()
Only for numpy-supported values.
Cannot reproduce locally.
c71a7e9 to
e02ea53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements most of the Python-facing part of #289. I feel that this is a definite improvement, in particular since it will be less confusing for someone familiar with
numpyorxarray. Furthermore it decreases the API differences, so we are a step closer to interoperability.I opened #290 to solve some follow-up tasks.