-
Notifications
You must be signed in to change notification settings - Fork 21
Closed
Description
Currently values and variances of Variable and DataProxy returns a flat (1D) range of values.
- For better alignment with
numpyandxarray, returning an object with correct dimensionality would be better. For this we currently have thenumpyproperty. - The distinction may have made sense historically in the design process, but definitely after the recent redesign of
Datasetit does not seem to make much sense any more.
So, the suggestions/questions are:
- Remove the
numpyproperty. - Return N-D numpy-like-array from
valuesandvariances. - Change the
dimsproperty to return only the labels (as xarray), get shape fromvalues(or add ashapeproperty toVariableandDataProxy). - Should we also make this change on the C++ side?
- Any other thoughts/issues related to this?