Handle time-dependent transformations for monitors #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonHeybrock
requested changes
Dec 4, 2025
src/ess/reduce/nexus/workflow.py
Outdated
| return EmptyMonitor[RunType, MonitorType]( | ||
| nexus.extract_signal_data_array(monitor).assign_coords( | ||
| position=monitor['position'] + offset.to(unit=monitor['position'].unit), | ||
| position=transform.value * offset.to(unit=transform.value.unit), |
Member
There was a problem hiding this comment.
This does not look right, comparing to the detector: The offset is a naive offset that we first introduced to handle ISIS SANS. It is applied as raw offset to the positions. Note the difference between offsets (the pixel offsets) and offset in detector provider above. Here the equivalent to offsets would be (0,0,0), so we should have T*(0,0,0)+offset, I think.
Member
There was a problem hiding this comment.
Well, maybe it is equivalent in practice, given that T is almost always a plain translation?
Member
Author
There was a problem hiding this comment.
Yes I wasn't sure how to combine the offset with the transform.
I will go with T*(0,0,0)+offset 👍
SimonHeybrock
approved these changes
Dec 4, 2025
jl-wynen
added a commit
to scipp/essdiffraction
that referenced
this pull request
Dec 5, 2025
Required to work around scipp/essreduce#290
jl-wynen
added a commit
to scipp/esssans
that referenced
this pull request
Dec 8, 2025
Required to work around scipp/essreduce#290
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loki monitor 4 has a time-dependent transform which we did not handle.
The transform is correctly handled for detectors, but not monitors.
This PR fixes this.
I checked that this did not change the positions of the other monitors (i.e. non time-dependent transforms should still work as before and give the same result), but this does change the API of the
get_calibrated_monitorfunction.I don't know if this gets imported and used directly outside of the
GenericNeXusWorkflow...This would fix https://git.esss.dk/dmsc-nightly/dmsc-nightly/-/issues/52