Skip to content

Build wheels#66

Merged
rth merged 12 commits intoscikit-learn-contrib:masterfrom
rth:build-wheels
Jun 26, 2020
Merged

Build wheels#66
rth merged 12 commits intoscikit-learn-contrib:masterfrom
rth:build-wheels

Conversation

@rth
Copy link
Copy Markdown
Contributor

@rth rth commented Jun 26, 2020 •
edited
Loading

Build wheels with cibuildwheel.

Closes #59

If we are feeling adventurous we could even push to PyPi on tags.

@rth rth marked this pull request as ready for review June 26, 2020 21:56
@rth
Copy link
Copy Markdown
Contributor Author

rth commented Jun 26, 2020 •
edited
Loading

I'm quite impressed with cibuildwheel . That relatively simple config builds and tests the following wheels in 3 CI jobs. Maybe we should consider it for scikit-learn though it probably gives less flexibility cc @thomasjpfan

scikit-learn-extra-0.1.0b2.tar.gz
scikit_learn_extra-0.1.0b2-cp36-cp36m-macosx_10_9_x86_64.whl
scikit_learn_extra-0.1.0b2-cp36-cp36m-manylinux1_i686.whl
scikit_learn_extra-0.1.0b2-cp36-cp36m-manylinux1_x86_64.whl
scikit_learn_extra-0.1.0b2-cp36-cp36m-manylinux2010_i686.whl
scikit_learn_extra-0.1.0b2-cp36-cp36m-manylinux2010_x86_64.whl
scikit_learn_extra-0.1.0b2-cp36-cp36m-win32.whl
scikit_learn_extra-0.1.0b2-cp36-cp36m-win_amd64.whl
scikit_learn_extra-0.1.0b2-cp37-cp37m-macosx_10_9_x86_64.whl
scikit_learn_extra-0.1.0b2-cp37-cp37m-manylinux1_i686.whl
scikit_learn_extra-0.1.0b2-cp37-cp37m-manylinux1_x86_64.whl
scikit_learn_extra-0.1.0b2-cp37-cp37m-manylinux2010_i686.whl
scikit_learn_extra-0.1.0b2-cp37-cp37m-manylinux2010_x86_64.whl
scikit_learn_extra-0.1.0b2-cp37-cp37m-win32.whl
scikit_learn_extra-0.1.0b2-cp37-cp37m-win_amd64.whl
scikit_learn_extra-0.1.0b2-cp38-cp38-macosx_10_9_x86_64.whl
scikit_learn_extra-0.1.0b2-cp38-cp38-manylinux1_i686.whl
scikit_learn_extra-0.1.0b2-cp38-cp38-manylinux1_x86_64.whl
scikit_learn_extra-0.1.0b2-cp38-cp38-manylinux2010_i686.whl
scikit_learn_extra-0.1.0b2-cp38-cp38-manylinux2010_x86_64.whl
scikit_learn_extra-0.1.0b2-cp38-cp38-win32.whl
scikit_learn_extra-0.1.0b2-cp38-cp38-win_amd64.whl

not sure why there are both manylinux2010 and manylinux1 wheel.

I disabled PyPy wheels as they was failing while installing scipy due to missing BLAS (MacPython/scipy-wheels#87 would fix it). It was building fine, the issue was while installing test dependencies (and I'm not sure how to skip running tests for PyPy).

Merging. I'll experiment with uploading RC to test.pypi.org with this CI in another PR.

@rth rth merged commit a6569b2 into scikit-learn-contrib:master Jun 26, 2020
@rth rth deleted the build-wheels branch June 26, 2020 22:07
@thomasjpfan
Copy link
Copy Markdown
Member

thomasjpfan commented Jun 26, 2020

I think cibuildwheel is worth checking out.

not sure why there are both manylinux2010 and manylinux1 wheel.

My initial thought would be that cibuildwheel would have build all the variations of manylinux*.

On a similar note, it looks like numpy builds manylinux1, 2010, and 2014 and scikit-learn only builds manylinux1.

(When I pip install numpy on ubuntu 18.04 I get the manylinux2010)

@rth rth mentioned this pull request Jul 1, 2020
Closed
TimotheeMathieu pushed a commit to TimotheeMathieu/scikit-learn-extra that referenced this pull request Oct 4, 2020
@rth
Build wheels (scikit-learn-contrib#66)
076fa4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build wheels

2 participants

@rth @thomasjpfan