[MRG + 1] Improve the output of example plot_iris.py after matplotlib2.0#9541
Merged
jnothman merged 2 commits intoscikit-learn:masterfrom Aug 15, 2017
qinhanmin2014:my-feature-3
Merged
[MRG + 1] Improve the output of example plot_iris.py after matplotlib2.0#9541jnothman merged 2 commits intoscikit-learn:masterfrom qinhanmin2014:my-feature-3
jnothman merged 2 commits intoscikit-learn:masterfrom
qinhanmin2014:my-feature-3
Conversation
Member
|
Cool. Can you check if the new colors you chose work for people with red-green color blindness? |
Member
Author
|
@amueller Thanks. I use vischeck to check it, the result seems to be OK (RdYlBu is also used in similar examples like plot_forest_iris.html) |
Member
|
thanks! LGTM |
Member
|
LGTM |
Member
|
Thanks, @qinhanmin2014 |
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Aug 30, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
part of #8364
note that the plot in 0.18(before matplotlib2.0) is also not good so I also modify some other things
What does this implement/fix? Explain your changes.
Below are the results from Circle CI
new version:
old version in 0.19/dev:
old version in 0.18: