[MRG + 1] Fixed impossible min_samples_split value#9520
Merged
NelleV merged 1 commit intoscikit-learn:masterfrom Aug 11, 2017
Merged
[MRG + 1] Fixed impossible min_samples_split value#9520NelleV merged 1 commit intoscikit-learn:masterfrom
NelleV merged 1 commit intoscikit-learn:masterfrom
Conversation
Member
|
Hi @diegodlh |
Contributor
Author
Member
|
I think the fix is correct. lgtm |
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Aug 30, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
None
What does this implement/fix? Explain your changes.
Fixed impossible min_samples_split=1 value in User Guide's Ensemble Methods section. Values of 0 and 1 are not allowed.
Any other comments?
None