[MRG+1] Rearrange modules in alphabetical order#9449
Merged
TomDLT merged 2 commits intoscikit-learn:masterfrom Jul 27, 2017
Merged
[MRG+1] Rearrange modules in alphabetical order#9449TomDLT merged 2 commits intoscikit-learn:masterfrom
TomDLT merged 2 commits intoscikit-learn:masterfrom
Conversation
jnothman
reviewed
Jul 25, 2017
Member
jnothman
left a comment
There was a problem hiding this comment.
the issue was about modules, not classes. For example discriminant_analysis is between k and l.
Some or all of these changes may be helpful but were not the point.
Contributor
Author
|
Ok, got it. Should I retain or revert old change? |
jnothman
reviewed
Jul 25, 2017
Member
jnothman
left a comment
There was a problem hiding this comment.
I think this is good, even if it's not what it says it is.
There are a couple of places where using alphabetical order obscures the key classes, notably neighbors and perhaps gaussian_process.kernels. But I figure that the key classes can be found in the narrative docs.
LGTM
Contributor
Author
|
@jnothman This PR is ready for review. |
Member
|
Checked the table of contents at http://scikit-learn.org/circle?12466/modules/classes.html. LGTM. |
Contributor
Author
|
Ok, thank you. |
Member
|
Thanks @bmanohar16 |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Aug 6, 2017
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #9448
What does this implement/fix? Explain your changes.
Rearranges modules in alphabetical order in classes.rst