[MRG+1] Remove unused imports#9235
Merged
GaelVaroquaux merged 1 commit intoscikit-learn:masterfrom Jul 1, 2017
Merged
Conversation
Member
|
You need a space between # and noqa to pass flake8 |
Contributor
Author
|
Removed the space. All checks passing now. |
lesteve
requested changes
Jun 28, 2017
Member
lesteve
left a comment
There was a problem hiding this comment.
The imports in __init__.py meant to expose names in the top-level package should be added to __all__ rather than using # noqa
sklearn/linear_model/__init__.py
Outdated
| MultiTaskLassoCV) | ||
| from .huber import HuberRegressor | ||
| from .sgd_fast import Hinge, Log, ModifiedHuber, SquaredLoss, Huber | ||
| from .sgd_fast import Hinge, Log, ModifiedHuber, SquaredLoss, Huber # noqa |
sklearn/metrics/__init__.py
Outdated
| from .classification import accuracy_score | ||
| from .classification import classification_report | ||
| from .classification import cohen_kappa_score | ||
| from .classification import cohen_kappa_score # noqa |
sklearn/metrics/__init__.py
Outdated
| from .cluster import mutual_info_score | ||
| from .cluster import normalized_mutual_info_score | ||
| from .cluster import fowlkes_mallows_score | ||
| from .cluster import fowlkes_mallows_score # noqa |
sklearn/metrics/__init__.py
Outdated
| from .cluster import silhouette_samples | ||
| from .cluster import silhouette_score | ||
| from .cluster import calinski_harabaz_score | ||
| from .cluster import calinski_harabaz_score # noqa |
Contributor
Author
|
@lesteve Thanks for pointing that out. I initially thought that these packages were still WIP. |
lesteve
reviewed
Jun 28, 2017
sklearn/utils/graph.py
Outdated
| import numpy as np | ||
| from scipy import sparse | ||
|
|
||
| from .validation import check_array |
Member
|
yes, I'd meant to look for those but forgot in the moment of review. thanks
@lesteve for catching it
|
Member
|
I feel like I'm getting sloppier at reviewing in general. I blame it on
part on using a smart phone for such things more often.
|
Contributor
Author
Member
|
LGTM |
| @@ -1,2 +1,2 @@ | |||
| from .pls_ import * | |||
| from .cca_ import * | |||
Member
There was a problem hiding this comment.
The right fix would have been to get rid of this "import *" (which is horrible), and only import the estimators, then exposed in all.
Hopefully in another PR?
Member
|
LGTM. Merging |
massich
pushed a commit
to massich/scikit-learn
that referenced
this pull request
Jul 13, 2017
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #9191
What does this implement/fix? Explain your changes.
This PR removes unused imports. For other issues still detected by
pyflakesfor notfix are commented with# noqa