[MRG + 2] check_array Error message#9126
Merged
lesteve merged 5 commits intoscikit-learn:masterfrom Jun 26, 2017
Merged
Conversation
Member
|
If it's fine by you, @lesteve, please merge. |
lesteve
reviewed
Jun 15, 2017
| X_array = check_array([0, 1, 2], ensure_2d=False) | ||
| assert_equal(X_array.ndim, 1) | ||
| # ensure_2d (True case) | ||
| assert_raises(ValueError, check_array, [0, 1, 2], ensure_2d=True) |
Member
There was a problem hiding this comment.
Check the error message please, e.g. with assert_raises_regex
lesteve
reviewed
Jun 15, 2017
| X_csr = sp.csr_matrix(X) | ||
| assert_raises(TypeError, check_array, X_csr) | ||
| # ensure_2d | ||
| # ensure_2d (False case) |
Member
There was a problem hiding this comment.
not really crucial but ensure_2d=False and ensure_2d=True reads better to me.
Member
|
Small additional comment: markdown formatting does not work in PR/issue titles. |
check_array Error message
lesteve
reviewed
Jun 16, 2017
| X_array = check_array([0, 1, 2], ensure_2d=False) | ||
| assert_equal(X_array.ndim, 1) | ||
| # ensure_2d=True | ||
| assert_raises(ValueError, check_array, [0, 1, 2], ensure_2d=True) |
Member
There was a problem hiding this comment.
Check the error message please, e.g. with assert_raises_regex
My old comment is still valid.
Member
|
LGTM, though I prefer newlines before the (usually lengthy) array starts. |
Member
|
I am going to merge this one, thanks @massich! |
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #9047, continues #9068 since some comments from @lesteve didn't make it before the merge.
What does this implement/fix? Explain your changes.
Any other comments?
@jnothman can you set it as a milestone (as in #9068)