[MRG] Improve the time of DBSCAN (partly revert #6799)#9118
Merged
ogrisel merged 1 commit intoscikit-learn:masterfrom Jun 15, 2017
qinhanmin2014:my-feature-3
Merged
[MRG] Improve the time of DBSCAN (partly revert #6799)#9118ogrisel merged 1 commit intoscikit-learn:masterfrom qinhanmin2014:my-feature-3
ogrisel merged 1 commit intoscikit-learn:masterfrom
qinhanmin2014:my-feature-3
Conversation
Member
|
LGTM. But you knew that. Why WIP? |
Member
|
@agramfort, as per #8619, are you okay to revert #6799? I believe that the right solution for DBSCAN memory issues is along the lines of #6813: a memory-efficient mode that changes its asymptotic space complexity. As long as we don't do that, we shouldn't bother with small memory optimisations and should maintain a good runtime. |
Member
Author
|
@jnothman Waiting for CI. Thanks for your precious time. |
Member
|
yes you can revert if you think it's best.
merge when you're happy
|
Member
|
+1 as well. The appveyor failures are not related. Merging. |
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixed #8619
What does this implement/fix? Explain your changes.
Please refer to the issue. I only revert part of #6799 bacause it also modify the document(seem to be useful).
Any other comments?