[MRG+1] don't set fit_params in __init__ in BaseSearchCV#9038
Merged
TomDLT merged 2 commits intoscikit-learn:masterfrom Jun 9, 2017
Merged
[MRG+1] don't set fit_params in __init__ in BaseSearchCV#9038TomDLT merged 2 commits intoscikit-learn:masterfrom
TomDLT merged 2 commits intoscikit-learn:masterfrom
Conversation
Member
|
LGTM. 👍 for merge |
Member
|
LGTM |
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
…n#9038) * don't set fit_params in __init__ in BaseSearchCV * fix doctest
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
…n#9038) * don't set fit_params in __init__ in BaseSearchCV * fix doctest
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
…n#9038) * don't set fit_params in __init__ in BaseSearchCV * fix doctest
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
…n#9038) * don't set fit_params in __init__ in BaseSearchCV * fix doctest
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
…n#9038) * don't set fit_params in __init__ in BaseSearchCV * fix doctest
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
…n#9038) * don't set fit_params in __init__ in BaseSearchCV * fix doctest
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
…n#9038) * don't set fit_params in __init__ in BaseSearchCV * fix doctest
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
…n#9038) * don't set fit_params in __init__ in BaseSearchCV * fix doctest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this needs a test.
Currently BaseSearchCV violates the API by changing fit_params in
__init__.