Skip to content

[MRG] DOC More detailed pull request and fork instructions (#8530)#8538

Merged
lesteve merged 2 commits intoscikit-learn:masterfrom
tfolkman:update-pull-req-instr
Mar 7, 2017
Merged

[MRG] DOC More detailed pull request and fork instructions (#8530)#8538
lesteve merged 2 commits intoscikit-learn:masterfrom
tfolkman:update-pull-req-instr

Conversation

@tfolkman
Copy link
Copy Markdown
Contributor

@tfolkman tfolkman commented Mar 5, 2017 •
edited by lesteve
Loading

Reference Issue

Fixes #8530.

What does this implement/fix? Explain your changes.

Any other comments?

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2017 •
edited
Loading

Codecov Report

Merging #8538 into master will decrease coverage by -0.73%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8538      +/-   ##
==========================================
- Coverage   95.48%   94.76%   -0.73%     
==========================================
  Files         342      342              
  Lines       61000    61013      +13     
==========================================
- Hits        58246    57818     -428     
- Misses       2754     3195     +441
Impacted Files Coverage Δ
sklearn/feature_extraction/tests/test_image.py 4.78% <0%> (-95.22%) ❌
sklearn/utils/sparsetools/tests/test_traversal.py 53.84% <0%> (-46.16%) ❌
sklearn/feature_extraction/image.py 58.16% <0%> (-41.84%) ❌
sklearn/utils/fixes.py 73.1% <0%> (-11.35%) ❌
sklearn/utils/sparsetools/_graph_validation.py 48.38% <0%> (-9.68%) ❌
sklearn/utils/tests/test_estimator_checks.py 88.23% <0%> (-7.57%) ❌
sklearn/utils/tests/test_utils.py 92.94% <0%> (-7.06%) ❌
sklearn/datasets/olivetti_faces.py 35.55% <0%> (-6.67%) ❌
sklearn/_build_utils/init.py 55.1% <0%> (-6.13%) ❌
sklearn/datasets/california_housing.py 36.84% <0%> (-5.27%) ❌
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5135c56...13a0db9. Read the comment docs.

@rishikksh20
Copy link
Copy Markdown
Contributor

rishikksh20 commented Mar 6, 2017

@tfolkman please add reference issue and other descriptions in PR description

lesteve
lesteve reviewed Mar 6, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@lesteve lesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a good idea to leverage off github instructions rather than maintain our own that are bound to become outdated after some time.

CONTRIBUTING.md Outdated
1. Fork the [project repository](https://github.com/scikit-learn/scikit-learn)
by clicking on the 'Fork' button near the top right of the page. This creates
a copy of the code under your GitHub user account.
a copy of the code under your GitHub user account. For more details on how to fork a repository see [this guide.](https://help.github.com/articles/fork-a-repo/)
Copy link
Copy Markdown
Member

@lesteve lesteve Mar 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your lines are too long. Find an editor that breaks lines after a decent width say 80.

@lesteve
Copy link
Copy Markdown
Member

lesteve commented Mar 6, 2017 •
edited
Loading

Please use "Fix #issueNumber" this way the associated issue gets closed automatically when the PR is merged. For more details, look at this.
I have edited your description but please bear this in mind for your next PR.

@tfolkman tfolkman force-pushed the update-pull-req-instr branch from 360c8b5 to bf2ab4f Compare March 6, 2017 17:38
@tfolkman
Copy link
Copy Markdown
Contributor Author

tfolkman commented Mar 6, 2017

Thank you - and sorry for the learning curve! I updated to make the lines shorter than 80 characters.

@jnothman
Copy link
Copy Markdown
Member

jnothman commented Mar 6, 2017

Well @amueller in #8530 wanted mention of the automatically appearing create pull request button, but I personally think it's too confusing to document and am fine with these changes.

@lesteve
Copy link
Copy Markdown
Member

lesteve commented Mar 7, 2017 •
edited
Loading

I pushed some minor tweaks in the markdown. With these LGTM, merging thanks!

@lesteve lesteve merged commit 618f8d2 into scikit-learn:master Mar 7, 2017
@Przemo10 Przemo10 mentioned this pull request Mar 17, 2017
Closed
herilalaina pushed a commit to herilalaina/scikit-learn that referenced this pull request Mar 26, 2017
@tfolkman @herilalaina
[MRG] DOC More detailed pull request and fork instructions (scikit-le…
7de41c2 
…arn#8530) (scikit-learn#8538)
massich pushed a commit to massich/scikit-learn that referenced this pull request Apr 26, 2017
@tfolkman
[MRG] DOC More detailed pull request and fork instructions (scikit-le…
a4fd554 
…arn#8530) (scikit-learn#8538)
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
@tfolkman @Sundrique
[MRG] DOC More detailed pull request and fork instructions (scikit-le…
df962e1 
…arn#8530) (scikit-learn#8538)
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
@tfolkman @NelleV
[MRG] DOC More detailed pull request and fork instructions (scikit-le…
7ee99e4 
…arn#8530) (scikit-learn#8538)
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@tfolkman @paulha
[MRG] DOC More detailed pull request and fork instructions (scikit-le…
74888bd 
…arn#8530) (scikit-learn#8538)
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@tfolkman @maskani-moh
[MRG] DOC More detailed pull request and fork instructions (scikit-le…
4c3396b 
…arn#8530) (scikit-learn#8538)
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017
@tfolkman
[MRG] DOC More detailed pull request and fork instructions (scikit-le…
0b6d32b 
…arn#8530) (scikit-learn#8538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lesteve lesteve lesteve left review comments

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pull request instructions not up to date in dev docs.

5 participants

@tfolkman @rishikksh20 @lesteve @jnothman @NelleV