[MRG] Separated regression metrics from other metrics in test_sample_weight_invariance in metrics/tests/test_common.py #8537
Merged
GaelVaroquaux merged 6 commits intoscikit-learn:masterfrom Mar 5, 2017
Conversation
added 5 commits
March 4, 2017 16:25
Codecov Report
@@ Coverage Diff @@
## master #8537 +/- ##
==========================================
+ Coverage 95.48% 95.48% +<.01%
==========================================
Files 342 342
Lines 60987 61000 +13
==========================================
+ Hits 58233 58246 +13
Misses 2754 2754
Continue to review full report at Codecov.
|
jnothman
reviewed
Mar 5, 2017
sklearn/metrics/tests/test_common.py
Outdated
| # regression | ||
| y_true = random_state.random_sample(size=(n_samples,)) | ||
| y_pred = random_state.random_sample(size=(n_samples,)) | ||
| y_score = random_state.random_sample(size=(n_samples,)) |
Contributor
Author
There was a problem hiding this comment.
They are used in the yield statement in the for loop below. Did you mean just y_score?
sklearn/metrics/tests/test_common.py
Outdated
| if name not in REGRESSION_METRICS: | ||
| continue | ||
| if (name in METRICS_WITHOUT_SAMPLE_WEIGHT or | ||
| name in METRIC_UNDEFINED_BINARY): |
Member
There was a problem hiding this comment.
this condition is not applicable.
Contributor
Author
There was a problem hiding this comment.
Both conditions or just the latter (metric_undefined_binary)? The former is used because when removed regression tests fail
Member
There was a problem hiding this comment.
Obviously then just the latter!
Member
|
LGTM. Given that @jnothman was also +1, I am merging this. Thanks! |
Closed
herilalaina
pushed a commit
to herilalaina/scikit-learn
that referenced
this pull request
Mar 26, 2017
…weight_invariance in metrics/tests/test_common.py (scikit-learn#8537) * Separated tests for regression features in test_sample_weight_invariance * Fixed pep8 * Removed unecessary check for regression * Updated regression metrics * Joel's suggestions
massich
pushed a commit
to massich/scikit-learn
that referenced
this pull request
Apr 26, 2017
…weight_invariance in metrics/tests/test_common.py (scikit-learn#8537) * Separated tests for regression features in test_sample_weight_invariance * Fixed pep8 * Removed unecessary check for regression * Updated regression metrics * Joel's suggestions
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
…weight_invariance in metrics/tests/test_common.py (scikit-learn#8537) * Separated tests for regression features in test_sample_weight_invariance * Fixed pep8 * Removed unecessary check for regression * Updated regression metrics * Joel's suggestions
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
…weight_invariance in metrics/tests/test_common.py (scikit-learn#8537) * Separated tests for regression features in test_sample_weight_invariance * Fixed pep8 * Removed unecessary check for regression * Updated regression metrics * Joel's suggestions
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
…weight_invariance in metrics/tests/test_common.py (scikit-learn#8537) * Separated tests for regression features in test_sample_weight_invariance * Fixed pep8 * Removed unecessary check for regression * Updated regression metrics * Joel's suggestions
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
…weight_invariance in metrics/tests/test_common.py (scikit-learn#8537) * Separated tests for regression features in test_sample_weight_invariance * Fixed pep8 * Removed unecessary check for regression * Updated regression metrics * Joel's suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
#6551