[MRG + 2] Deprecated comparison to string in GP#8518
Merged
jmschrei merged 1 commit intoscikit-learn:masterfrom Mar 4, 2017
Merged
[MRG + 2] Deprecated comparison to string in GP#8518jmschrei merged 1 commit intoscikit-learn:masterfrom
jmschrei merged 1 commit intoscikit-learn:masterfrom
Conversation
Member
|
LGTM, thanks. |
Member
|
LGTM as well, and seems to remove all of the warnings. It looks like appveyor is behind on the tests though. |
Member
|
@Namiya for the future, please comment on an issue if you're working on it so it's easier to coordinate. |
Contributor
Author
|
@amueller I worked with zxcvbnius together in the sprint event. And we did comment on the issue you raised. |
Codecov Report
@@ Coverage Diff @@
## master #8518 +/- ##
==========================================
+ Coverage 95.48% 95.48% +<.01%
==========================================
Files 342 342
Lines 60913 60915 +2
==========================================
+ Hits 58160 58162 +2
Misses 2753 2753
Continue to review full report at Codecov.
|
Member
|
This passes all tests so I'm merging it now. Thanks @Namiya and zxcvbnius! |
Closed
herilalaina
pushed a commit
to herilalaina/scikit-learn
that referenced
this pull request
Mar 26, 2017
massich
pushed a commit
to massich/scikit-learn
that referenced
this pull request
Apr 26, 2017
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #8503
What does this implement/fix? Explain your changes.
Any other comments?