[MRG] removed download_url in setup.py#8513
Conversation
|
Is the consensus that we want to remove the download URL? I would have thought about changing it to point to pypi? |
|
I made some tests as pointed by @lesteve. Our conversations can be checked in the previous commit for the same issue by some other author @GaelVaroquaux .Thanks. |
Codecov Report
@@ Coverage Diff @@
## master #8513 +/- ##
=======================================
Coverage 95.48% 95.48%
=======================================
Files 342 342
Lines 60913 60913
=======================================
Hits 58160 58160
Misses 2753 2753Continue to review full report at Codecov.
|
Then you have a link on PyPI that points to the page you are already on. I don't think it adds anything. Thanks @shubham0704 for going through the tests I mentioned in #8205 (comment). For next time, use your PR to comment on the tests you did rather than someone else's PR. For further reference they are here. I am going to merge this one, I feel there was enough discussion already given the limited scope of this change and it is easy enough to revert it, if we bump into a unintended side-effect, which I doubt. |
|
Sure @lesteve . Thanks a lot. |
Reference Issue
Fix #8184. Closes #8205.
What does this implement/fix? Explain your changes.
Removed DOWNLOAD_URL
Any other comments?