Codecov Report

Merging #8502 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8502   +/-   ##
=======================================
  Coverage   95.48%   95.48%           
=======================================
  Files         342      342           
  Lines       60913    60913           
=======================================
  Hits        58160    58160           
  Misses       2753     2753

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c7ab17...24afc5f. Read the comment docs.

thanks :)

LGTM

Thank you! This also makes me happy :)

didn't work :(

should have been "comment". Fixing in master...

should have been

comment: off

good thing we're reviewing so well.

For the record I think comments were useful and the fact that you only get one email per PR rather than one per-commit was a good trade-off as far as email noise is concerned.

Having said that I agree that there is a bit of noise in the numbers that codecov reports (which we should try to understand at some point) and that the one comment per PR does not always work for some unknown reason (I thought it was due to rebase and force-push but this doesn't seem like the culprit in some small tests I ran).