[MRG + 1] Update funding and website.#7836
Conversation
|
+1. Thanks |
doc/about.rst
Outdated
| Tom Dupré la Tour (2015), Thierry Guillemot (2016) and Raghav R V (2016) to | ||
| work on scikit-learn. | ||
|
|
||
| .. image:: http://f.hypotheses.org/wp-content/blogs.dir/331/files/2011/03/Logo-TPT.jpg |
There was a problem hiding this comment.
It might be good to add this image to our git. I worry that the URL given here will not last forever.
|
BTW, I have just updated people from Télécom but if you think about someone else, I can add them ;). |
GaelVaroquaux
left a comment
There was a problem hiding this comment.
Actually, circleCI doesn't build, and the reason is that the image file of telecom seems not to be reachable.
doc/about.rst
Outdated
| :target: http://cds.nyu.edu/mooresloan/ | ||
|
|
||
| `Télécom Paristech <http://www.telecom-paristech.com>`_ funds Manoj Kumar (2014), | ||
| Tom Dupré la Tour (2015), Thierry Guillemot (2016) and Raghav R V (2016) to |
There was a problem hiding this comment.
I think mine should be 2015 to current as I started in Oct 2015...
doc/about.rst
Outdated
| Tom Dupré la Tour (2015), Thierry Guillemot (2016) and Raghav R V (2016) to | ||
| work on scikit-learn. | ||
|
|
||
| .. image:: _static/img/telecom.png |
There was a problem hiding this comment.
And like @GaelVaroquaux points out, this file is missing?
There was a problem hiding this comment.
It's my fault indeed. This file is generated automatically with sphinx but it doesn't exist before the check is complete.
doc/about.rst
Outdated
| :target: http://cds.nyu.edu/mooresloan/ | ||
|
|
||
| `Télécom Paristech <http://www.telecom-paristech.com>`_ funds Manoj Kumar (2014), | ||
| Tom Dupré la Tour (2015), Raghav R V (2015-2016) Thierry Guillemot (2016) and to |
There was a problem hiding this comment.
Sorry I'm doing two things in the same time. Bad habits :)
|
LGTM. @GaelVaroquaux +1 and merge once the CIs pass? |
|
Once CI passes yes Sent from my phone. Please forgive brevity and mis spelling On Nov 7, 2016, 17:17, at 17:17, Raghav RV notifications@github.com wrote:
|
|
Thanks @tguillemot |
* Fix funding and website. * Update images and fix typos. * Fix images problem.
* Fix funding and website. * Update images and fix typos. * Fix images problem.
* Fix funding and website. * Update images and fix typos. * Fix images problem.
* Fix funding and website. * Update images and fix typos. * Fix images problem.
* Fix funding and website. * Update images and fix typos. * Fix images problem.
* Fix funding and website. * Update images and fix typos. * Fix images problem.
This PR update the funding section and add some links to the images of the section.