Skip to content

[MRG+1] replaced some assert_true(np.allclose(x, y)) with assert_almost_equal#7742

Merged
NelleV merged 2 commits intoscikit-learn:masterfrom
amueller:some_better_test_failure_messages
Oct 25, 2016
Merged

[MRG+1] replaced some assert_true(np.allclose(x, y)) with assert_almost_equal#7742
NelleV merged 2 commits intoscikit-learn:masterfrom
amueller:some_better_test_failure_messages

Conversation

@amueller
Copy link
Copy Markdown
Member

also some pep8.

@TomDLT
Copy link
Copy Markdown
Member

TomDLT commented Oct 25, 2016

LGTM

@TomDLT TomDLT changed the title replaced some assert_true(np.allclose(x, y)) with assert_almost_equal [MRG+1] replaced some assert_true(np.allclose(x, y)) with assert_almost_equal Oct 25, 2016
@tguillemot
Copy link
Copy Markdown
Contributor

LGTM

@NelleV NelleV merged commit 4da44c8 into scikit-learn:master Oct 25, 2016
amueller added a commit to amueller/scikit-learn that referenced this pull request Oct 25, 2016
amueller added a commit to amueller/scikit-learn that referenced this pull request Oct 27, 2016
sergeyf pushed a commit to sergeyf/scikit-learn that referenced this pull request Feb 28, 2017
…st_equal (scikit-learn#7742)

* replaced some assert_true(np.allclose(x, y)) with assert_almost_equal for better error messages.

also some pep8.

* typo fixes
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
…st_equal (scikit-learn#7742)

* replaced some assert_true(np.allclose(x, y)) with assert_almost_equal for better error messages.

also some pep8.

* typo fixes
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
…st_equal (scikit-learn#7742)

* replaced some assert_true(np.allclose(x, y)) with assert_almost_equal for better error messages.

also some pep8.

* typo fixes
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
…st_equal (scikit-learn#7742)

* replaced some assert_true(np.allclose(x, y)) with assert_almost_equal for better error messages.

also some pep8.

* typo fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants