[MRG + 1] Changed Contributor's Guide to Development Guide #7690#7691
Merged
jnothman merged 2 commits intoscikit-learn:masterfrom Oct 18, 2016
aferritto:doc-update-7690
Merged
[MRG + 1] Changed Contributor's Guide to Development Guide #7690#7691jnothman merged 2 commits intoscikit-learn:masterfrom aferritto:doc-update-7690
jnothman merged 2 commits intoscikit-learn:masterfrom
aferritto:doc-update-7690
Conversation
Member
|
This one is also good, but in the issue I meant here: |
Member
|
LGTM. |
Contributor
Author
|
Looks like CircleCI is timing out |
Member
|
Thanks @FERRIA |
amueller
pushed a commit
to amueller/scikit-learn
that referenced
this pull request
Oct 25, 2016
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
#7690
What does this implement/fix? Explain your changes.
Changed the name of the link to the developer's guide to "development" from "contributor's".
Any other comments?
Could also change name to "Developer's Guide" to match what the linked to page says if that would be preferred. I ran the
makeandmake flake8-difftests and got some warnings/errors, even though I never changed the code. Can post the exact messages if anyone wants them but figured I'd open this anyways to get this started.