Skip to content

[MRG] better docstring for TruncatedSVD#7651

Merged
jnothman merged 1 commit intoscikit-learn:masterfrom
ogrisel:docstring-truncated-svd
Oct 13, 2016
Merged

[MRG] better docstring for TruncatedSVD#7651
jnothman merged 1 commit intoscikit-learn:masterfrom
ogrisel:docstring-truncated-svd

Conversation

@ogrisel
Copy link
Copy Markdown
Member

@ogrisel ogrisel commented Oct 12, 2016

The current dosctring is inaccurate and confusing. Hopefully this will help users with such questions:

http://stats.stackexchange.com/questions/239481/difference-between-scikit-learn-implementations-of-pca-and-truncatedsvd/239537#239537

@ogrisel ogrisel changed the title [MRG ] better docstring for TruncatedSVD [MRG] better docstring for TruncatedSVD Oct 12, 2016
@giorgiop
Copy link
Copy Markdown
Contributor

LGTM

@jnothman jnothman merged commit d8614a3 into scikit-learn:master Oct 13, 2016
amueller pushed a commit to amueller/scikit-learn that referenced this pull request Oct 14, 2016
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants