Skip to content

[MRG+1] DOC: fix the copybutton on the code blocks#7634

Merged
TomDLT merged 1 commit intoscikit-learn:masterfrom
GaelVaroquaux:fix_copybutton
Oct 13, 2016
Merged

[MRG+1] DOC: fix the copybutton on the code blocks#7634
TomDLT merged 1 commit intoscikit-learn:masterfrom
GaelVaroquaux:fix_copybutton

Conversation

@GaelVaroquaux
Copy link
Copy Markdown
Member

The copybutton is the ">>>" on the side of code blocks that enables to remove the ">>>" at the beginning of lines as well as the outputs.

See for instance the code blocks on http://scikit-learn.org/0.17/tutorial/text_analytics/working_with_text_data.html#tutorial-setup

It was broken in the docs of 0.18 due to changes in sphinx. See:
http://scikit-learn.org/stable/tutorial/text_analytics/working_with_text_data.html#tutorial-setup

I am backporting the js used by the Python core docs.

In addition, I am porting CSS from scipy-lectures to highlight this button on hover, and make it more discoverable.

The copybutton is the ">>>" on the side of code blocks that enables to
remove the ">>>" at the begining of lines as well as the outputs.

It was broken in the docs of 0.18 due to changes in sphinx. I am
backporting the js used by the Python core docs.

In addition, I am backporting CSS to highlight this button
on hover.
@amueller
Copy link
Copy Markdown
Member

wow I never noticed this feature.

@amueller amueller added this to the 0.18.1 milestone Oct 10, 2016
@amueller
Copy link
Copy Markdown
Member

can you post a link to the artifact?

@GaelVaroquaux
Copy link
Copy Markdown
Member Author

What do you mean the artifact? I posted a link to a page showing the bug in 0.18, and not showing it in 0.17.

@GaelVaroquaux
Copy link
Copy Markdown
Member Author

@jnothman
Copy link
Copy Markdown
Member

LGTM!

@jnothman jnothman changed the title [MRG] DOC: fix the copybutton on the code blocks [MRG+1] DOC: fix the copybutton on the code blocks Oct 13, 2016
@TomDLT TomDLT merged commit 0e12b2f into scikit-learn:master Oct 13, 2016
amueller pushed a commit to amueller/scikit-learn that referenced this pull request Oct 14, 2016
The copybutton is the ">>>" on the side of code blocks that enables to
remove the ">>>" at the begining of lines as well as the outputs.

It was broken in the docs of 0.18 due to changes in sphinx. I am
backporting the js used by the Python core docs.

In addition, I am backporting CSS to highlight this button
on hover.
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
The copybutton is the ">>>" on the side of code blocks that enables to
remove the ">>>" at the begining of lines as well as the outputs.

It was broken in the docs of 0.18 due to changes in sphinx. I am
backporting the js used by the Python core docs.

In addition, I am backporting CSS to highlight this button
on hover.
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
The copybutton is the ">>>" on the side of code blocks that enables to
remove the ">>>" at the begining of lines as well as the outputs.

It was broken in the docs of 0.18 due to changes in sphinx. I am
backporting the js used by the Python core docs.

In addition, I am backporting CSS to highlight this button
on hover.
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
The copybutton is the ">>>" on the side of code blocks that enables to
remove the ">>>" at the begining of lines as well as the outputs.

It was broken in the docs of 0.18 due to changes in sphinx. I am
backporting the js used by the Python core docs.

In addition, I am backporting CSS to highlight this button
on hover.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants