Rangespan testimonial has misformatted link#7576
Merged
NelleV merged 1 commit intoscikit-learn:masterfrom Oct 4, 2016
Merged
Conversation
Contributor
|
LGTM I don't think we need a disclaimer because the site itself has that info. |
Member
|
Thanks! |
Contributor
Author
|
@NelleV Thanks for merging my PR |
amueller
pushed a commit
to amueller/scikit-learn
that referenced
this pull request
Oct 14, 2016
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
Rangespan testimonial has misformatted link #7521
Fixed the formatting and URL of the Rangespan testimonial by changing the URL to use http instead of https and move the underscore so it goes from
Rangespan <https://www.rangespan.com>_(improperly formatted rst link with https)to
Rangespan <http://www.rangespan.com>_ (properly formatted rst link with http)I feel, we can add an extra comment/line in the section indicating that Rangeapan is been acquired by Google and their site is inactive now. This may avoid confusion.