Skip to content

[MRG] Fix flake8_diff.sh git repo unshallowing#7575

Merged
lesteve merged 1 commit intoscikit-learn:masterfrom
lesteve:fix-flake8-diff-unshallowing
Oct 4, 2016
Merged

[MRG] Fix flake8_diff.sh git repo unshallowing#7575
lesteve merged 1 commit intoscikit-learn:masterfrom
lesteve:fix-flake8-diff-unshallowing

Conversation

@lesteve
Copy link
Copy Markdown
Member

@lesteve lesteve commented Oct 4, 2016

which fixes the issue seen in #7027 (comment).

Enhancements:

  • the script works on PRs targetting a fork rather than the reference
    repo
  • improved logic about when to unshallow the repo
  • fetching the upstream master branch into a reference rather than a
    branch (less intrusive for scripts than may run afterwards e.g. the
    ones in the after_success step)
  • Better logging messages

I'll just wait the CI on this one and probably merge if everything is green.

which fixes the issue seen in
scikit-learn#7027.

Enhancements:
* the script works on PRs targetting a fork rather than the reference
  repo
* improved logic about when to unshallow the repo
* fetching the upstream master branch into a reference rather than a
  branch (less intrusive for scripts than may run afterwards e.g. the
  ones in the after_success step)
* Better logging messages
@lesteve
Copy link
Copy Markdown
Member Author

lesteve commented Oct 4, 2016

OK the Travis build looks good so I'll merge this one.

@lesteve lesteve merged commit 20912ed into scikit-learn:master Oct 4, 2016
@lesteve lesteve deleted the fix-flake8-diff-unshallowing branch October 4, 2016 17:29
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
which fixes the issue seen in
scikit-learn#7027.

Enhancements:
* the script works on PRs targetting a fork rather than the reference
  repo
* improved logic about when to unshallow the repo
* fetching the upstream master branch into a reference rather than a
  branch (less intrusive for scripts than may run afterwards e.g. the
  ones in the after_success step)
* Better logging messages
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
which fixes the issue seen in
scikit-learn#7027.

Enhancements:
* the script works on PRs targetting a fork rather than the reference
  repo
* improved logic about when to unshallow the repo
* fetching the upstream master branch into a reference rather than a
  branch (less intrusive for scripts than may run afterwards e.g. the
  ones in the after_success step)
* Better logging messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant