Skip to content

[MRG+1] minor link fix for SAG paper.#7523

Merged
TomDLT merged 3 commits intoscikit-learn:masterfrom
iamprakashom:feature
Sep 29, 2016
Merged

[MRG+1] minor link fix for SAG paper.#7523
TomDLT merged 3 commits intoscikit-learn:masterfrom
iamprakashom:feature

Conversation

@iamprakashom
Copy link
Copy Markdown
Contributor

Reference Issue

Fixes #7512

updates link to SAG paper in the LinearRegression user guide.

SAG paper cited in Reference section of docstring of LogisticRegression.

updates link to SAG paper in References section of SAG Solvers.

link to SAG paper in `References` section updated (scikit-learn#7512).
@jnothman
Copy link
Copy Markdown
Member

LGTM

@jnothman jnothman changed the title [MRG] minor link fix for SAG paper. [MRG+1] minor link fix for SAG paper. Sep 29, 2016
@jnothman
Copy link
Copy Markdown
Member

Except

./sklearn/linear_model/logistic.py:219:80: E501 line too long (80 > 79 characters)
                                               shape=(n_samples, n_samples)), X)

dead link of SAG paper in Logistic Regression user guide updated.
resolves scikit-learn#7512
SAG paper cited in `Reference` section of docstring(scikit-learn#7512).
@iamprakashom
Copy link
Copy Markdown
Contributor Author

@jnothman, done. kindly review. 😄

@TomDLT TomDLT merged commit 32236ff into scikit-learn:master Sep 29, 2016
@iamprakashom iamprakashom deleted the feature branch September 29, 2016 11:43
@iamprakashom iamprakashom restored the feature branch September 29, 2016 19:50
@iamprakashom iamprakashom deleted the feature branch September 29, 2016 19:51
TomDLT pushed a commit to TomDLT/scikit-learn that referenced this pull request Oct 3, 2016
* Link to SAG paper updated

link to SAG paper in `References` section updated (scikit-learn#7512).

* Link to SAG paper updated

dead link of SAG paper in Logistic Regression user guide updated.
resolves scikit-learn#7512

* SAG paper cited in docstring

SAG paper cited in `Reference` section of docstring(scikit-learn#7512).
amueller pushed a commit to amueller/scikit-learn that referenced this pull request Oct 14, 2016
* Link to SAG paper updated

link to SAG paper in `References` section updated (scikit-learn#7512).

* Link to SAG paper updated

dead link of SAG paper in Logistic Regression user guide updated.
resolves scikit-learn#7512

* SAG paper cited in docstring

SAG paper cited in `Reference` section of docstring(scikit-learn#7512).
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
* Link to SAG paper updated

link to SAG paper in `References` section updated (scikit-learn#7512).

* Link to SAG paper updated

dead link of SAG paper in Logistic Regression user guide updated.
resolves scikit-learn#7512

* SAG paper cited in docstring

SAG paper cited in `Reference` section of docstring(scikit-learn#7512).
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
* Link to SAG paper updated

link to SAG paper in `References` section updated (scikit-learn#7512).

* Link to SAG paper updated

dead link of SAG paper in Logistic Regression user guide updated.
resolves scikit-learn#7512

* SAG paper cited in docstring

SAG paper cited in `Reference` section of docstring(scikit-learn#7512).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants