Skip to content

fix lbfgs rename#7503

Merged
amueller merged 1 commit intoscikit-learn:masterfrom
amueller:lbfgs_rename_fix
Sep 27, 2016
Merged

fix lbfgs rename#7503
amueller merged 1 commit intoscikit-learn:masterfrom
amueller:lbfgs_rename_fix

Conversation

@amueller
Copy link
Copy Markdown
Member

@amueller amueller commented Sep 27, 2016

Fixes #7500

@amueller amueller mentioned this pull request Sep 27, 2016
Closed
@amueller amueller added this to the 0.18 milestone Sep 27, 2016
@nelson-liu
Copy link
Copy Markdown
Contributor

nelson-liu commented Sep 27, 2016

LGTM if CI passes

@amueller
Copy link
Copy Markdown
Member Author

amueller commented Sep 27, 2016

ping @ogrisel @jnothman this is the last thing needed for 0.18 :)

@agramfort
Copy link
Copy Markdown
Member

agramfort commented Sep 27, 2016

LGTM

@stonebig
Copy link
Copy Markdown

stonebig commented Sep 27, 2016

will we have scikit-optimize release today also ?

@amueller
Copy link
Copy Markdown
Member Author

amueller commented Sep 27, 2016

@stonebig don't know about that, did they plan to?

@amueller amueller merged commit 7901190 into scikit-learn:master Sep 27, 2016
amueller added a commit that referenced this pull request Sep 27, 2016
@amueller
fix lbfgs rename (#7503)
644dbcc
TomDLT pushed a commit to TomDLT/scikit-learn that referenced this pull request Oct 3, 2016
@amueller @TomDLT
fix lbfgs rename (scikit-learn#7503)
ada6e36
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Nov 10, 2016
@yarikoptic
Merge tag '0.18' into releases
ef8fa61 
* tag '0.18': (1286 commits)
  [MRG + 1] More versionadded everywhere! (scikit-learn#7403)
  minor doc fixes
  fix lbfgs rename (scikit-learn#7503)
  minor fixes to whatsnew
  fix scoring function table
  fix rebase messup
  DOC more what's new subdivision
  DOC Attempt to impose some order on What's New 0.18
  no fixed width within bold
  REL changes for release in 0.18.X branch (scikit-learn#7414)
  [MRG+2] Timing and training score in GridSearchCV (scikit-learn#7325)
  DOC: Added Nested Cross Validation Example (scikit-learn#7111)
  Sync docstring and definition default argument in kneighbors (scikit-learn#7476)
  added contributors for 0.18, minor formatting fixes.
  Fix typo in whats_new.rst
  [MRG+2] FIX adaboost estimators not randomising correctly (scikit-learn#7411)
  Addressing issue scikit-learn#7468. (scikit-learn#7472)
  Reorganize README
  clean up deprecation warning stuff in common tests
  [MRG+1] Fix regression in silhouette_score for clusters of size 1 (scikit-learn#7438)
  ...
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Nov 10, 2016
@yarikoptic
Merge branch 'releases' into dfsg
e78c6e6 
* releases: (1286 commits)
  [MRG + 1] More versionadded everywhere! (scikit-learn#7403)
  minor doc fixes
  fix lbfgs rename (scikit-learn#7503)
  minor fixes to whatsnew
  fix scoring function table
  fix rebase messup
  DOC more what's new subdivision
  DOC Attempt to impose some order on What's New 0.18
  no fixed width within bold
  REL changes for release in 0.18.X branch (scikit-learn#7414)
  [MRG+2] Timing and training score in GridSearchCV (scikit-learn#7325)
  DOC: Added Nested Cross Validation Example (scikit-learn#7111)
  Sync docstring and definition default argument in kneighbors (scikit-learn#7476)
  added contributors for 0.18, minor formatting fixes.
  Fix typo in whats_new.rst
  [MRG+2] FIX adaboost estimators not randomising correctly (scikit-learn#7411)
  Addressing issue scikit-learn#7468. (scikit-learn#7472)
  Reorganize README
  clean up deprecation warning stuff in common tests
  [MRG+1] Fix regression in silhouette_score for clusters of size 1 (scikit-learn#7438)
  ...
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Nov 10, 2016
@yarikoptic
Merge branch 'dfsg' into debian
e804609 
* dfsg: (1286 commits)
  [MRG + 1] More versionadded everywhere! (scikit-learn#7403)
  minor doc fixes
  fix lbfgs rename (scikit-learn#7503)
  minor fixes to whatsnew
  fix scoring function table
  fix rebase messup
  DOC more what's new subdivision
  DOC Attempt to impose some order on What's New 0.18
  no fixed width within bold
  REL changes for release in 0.18.X branch (scikit-learn#7414)
  [MRG+2] Timing and training score in GridSearchCV (scikit-learn#7325)
  DOC: Added Nested Cross Validation Example (scikit-learn#7111)
  Sync docstring and definition default argument in kneighbors (scikit-learn#7476)
  added contributors for 0.18, minor formatting fixes.
  Fix typo in whats_new.rst
  [MRG+2] FIX adaboost estimators not randomising correctly (scikit-learn#7411)
  Addressing issue scikit-learn#7468. (scikit-learn#7472)
  Reorganize README
  clean up deprecation warning stuff in common tests
  [MRG+1] Fix regression in silhouette_score for clusters of size 1 (scikit-learn#7438)
  ...
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
@amueller @Sundrique
fix lbfgs rename (scikit-learn#7503)
9038feb
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@amueller @paulha
fix lbfgs rename (scikit-learn#7503)
678f0be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Blocker

Projects

None yet

Milestone

0.18

Development

Successfully merging this pull request may close these issues.

4 participants

@amueller @nelson-liu @agramfort @stonebig