[MRG + 1] fixed comment in 20newsgroups example#7423
Merged
jnothman merged 1 commit intoscikit-learn:masterfrom Oct 25, 2016
Merged
[MRG + 1] fixed comment in 20newsgroups example#7423jnothman merged 1 commit intoscikit-learn:masterfrom
jnothman merged 1 commit intoscikit-learn:masterfrom
Conversation
Contributor
|
maybe have to rerun ci (i guess you can do this manually by simply pushing a spurious change and removing it) due to b1bd976 |
agramfort
reviewed
Sep 15, 2016
| print('data loaded') | ||
|
|
||
| categories = data_train.target_names # for case categories == None | ||
| categories = data_train.target_names # order may be different |
Member
There was a problem hiding this comment.
sorry but I find comment obscure
Contributor
Author
There was a problem hiding this comment.
Yeah, I agree. What do you think about the updated comment?
data_train.target_names must be used even if categories is not None because target_names order can be different from 'categories' order.
Contributor
Author
|
ping :) Will the PR be more mergeable if I just remove "order of labels in |
Member
|
lgtm |
Member
|
thanks |
amueller
pushed a commit
to amueller/scikit-learn
that referenced
this pull request
Oct 25, 2016
amueller
pushed a commit
to amueller/scikit-learn
that referenced
this pull request
Oct 27, 2016
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here:
data_train.target_namesmust be used as category names even if categories is not None because the order can be different fromcategoriesorder.