[MRG] add whatsnew for #7248 (unpickle version warning)#7400
[MRG] add whatsnew for #7248 (unpickle version warning)#7400jnothman merged 5 commits intoscikit-learn:masterfrom
Conversation
|
looks good to me, was going to comment on maybe clarifying trained vs pickled but i think one would be hard pressed to train in one version and pickle in another. |
doc/whats_new.rst
Outdated
| By `Andreas Müller`_. | ||
|
|
||
| - When unpickling a scikit-learn estimator in a different version than the one | ||
| the estimator was trained with, a ``UserWarning`` is raised. |
There was a problem hiding this comment.
|
+1 |
doc/whats_new.rst
Outdated
| - When unpickling a scikit-learn estimator in a different version than the one | ||
| the estimator was trained with, a ``UserWarning`` is raised, see `the documentation | ||
| on model persitance | ||
| <http://scikit-learn.org/stable/modules/model_persistence.html#security-maintainability-limitations>`_ |
There was a problem hiding this comment.
I'm sure there's a way to use sphinx anchors here... or are you trying to make this more user readable in the RST?
There was a problem hiding this comment.
you mean a named link and put the link at the bottom of the page? I could do that... for pep8?
There was a problem hiding this comment.
No, I meant an internal anchor link, so that a link in /dev/ will point to /dev/ rather than stable.
There was a problem hiding this comment.
ahhh that makes much more sense
doc/whats_new.rst
Outdated
|
|
||
| - When unpickling a scikit-learn estimator in a different version than the one | ||
| the estimator was trained with, a ``UserWarning`` is raised, see `the documentation | ||
| on model persistance |
There was a problem hiding this comment.
Sorry for the pickiness but I believe it is persistence with an "e" and not an "a" ...
No description provided.