[MRG+1] TST Stronger test for _check_is_permutation#7395
Merged
amueller merged 2 commits intoscikit-learn:masterfrom Sep 12, 2016
Merged
[MRG+1] TST Stronger test for _check_is_permutation#7395amueller merged 2 commits intoscikit-learn:masterfrom
amueller merged 2 commits intoscikit-learn:masterfrom
Conversation
Member
Author
|
@jnothman Revews for this one? The previous version will pass for |
Member
|
Sorry, I don't get what you're saying about the previous version. |
Member
|
Oh. I get what you're saying. You need a np.all. |
Member
|
I think the obvious case the test is missing is |
Member
Author
|
@jnothman Good now? |
Member
|
LGTM |
rsmith54
pushed a commit
to rsmith54/scikit-learn
that referenced
this pull request
Sep 14, 2016
* TST Stronger test for _check_is_permutation * TST Ensure additional duplicate indices are caught
TomDLT
pushed a commit
to TomDLT/scikit-learn
that referenced
this pull request
Oct 3, 2016
* TST Stronger test for _check_is_permutation * TST Ensure additional duplicate indices are caught
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
* TST Stronger test for _check_is_permutation * TST Ensure additional duplicate indices are caught
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
* TST Stronger test for _check_is_permutation * TST Ensure additional duplicate indices are caught
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses one of the issues of #5053
@vene I think this should address your comment.