[MRG + 1] Fail imputer early when number of features are not the same in fit and transform#7374
Merged
jnothman merged 2 commits intoscikit-learn:masterfrom Sep 11, 2016
Merged
Conversation
Member
|
LGTM, thanks :) |
Member
|
I guess the error message is covered? |
Member
Author
|
No, but it might be better to open a separate issue to raise a consistent error message when the number of features are different during |
Member
|
test would be nice... |
Member
Author
|
For all transformers? |
Member
|
I check the coverage report (run locally) and this specific value error is covered (by test_common ?). |
Member
|
+1 on my side. |
Member
|
Yes, yes, fine. Thanks :) |
Member
Author
|
The |
This was referenced Sep 13, 2016
rsmith54
pushed a commit
to rsmith54/scikit-learn
that referenced
this pull request
Sep 14, 2016
TomDLT
pushed a commit
to TomDLT/scikit-learn
that referenced
this pull request
Oct 3, 2016
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #7367
What does this implement/fix? Explain your changes.
It ( https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/utils/estimator_checks.py#L617) fails at some other point after the
VisibleDeprecationWarningis displayed, so maybe not so ominous in comparison to the other adventures in this part of the codebase :p