[MRG + 2] change installation description now that we have manylinux wheels#7313
Merged
lesteve merged 1 commit intoscikit-learn:masterfrom Sep 8, 2016
Merged
Conversation
Member
Author
|
ping @GaelVaroquaux ;) |
doc/install.rst
Outdated
| and NumPy and SciPy are not recompiled from source, which can happen when using | ||
| particular configurations of operating system and hardware (such as Linux on | ||
| a Raspberry Pi). We don't recommend installing numpy or scipy from source. | ||
| Instead, use a thrid-party distribution as described below. |
Member
|
LGTM. I ❤️ manylinux wheels |
doc/install.rst
Outdated
| conda or pip. When using pip, please ensure that *binary wheels* are used, | ||
| and NumPy and SciPy are not recompiled from source, which can happen when using | ||
| particular configurations of operating system and hardware (such as Linux on | ||
| a Raspberry Pi). We don't recommend installing numpy or scipy from source. |
Member
There was a problem hiding this comment.
Instead of the frightening "We don't recommend installing numpy or scipy from source." I would rather be slightly more specific:
Building numpy and scipy from source can be complex (especially on Windows) and requires careful configuration to ensure that they link against an optimized implementation of linear algebra routines.
…ing scipy or numpy with pip.
9297133 to
869adff
Compare
Member
Author
|
@ogrisel used your wording and tried to include the [alldeps] somehow. Good? |
Member
|
LGTM |
Member
|
I'll wait a bit to see if @ogrisel wants to comment further and if not I'll merge this one. |
rsmith54
pushed a commit
to rsmith54/scikit-learn
that referenced
this pull request
Sep 14, 2016
…ing scipy or numpy with pip. (scikit-learn#7313)
TomDLT
pushed a commit
to TomDLT/scikit-learn
that referenced
this pull request
Oct 3, 2016
…ing scipy or numpy with pip. (scikit-learn#7313)
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
…ing scipy or numpy with pip. (scikit-learn#7313)
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
…ing scipy or numpy with pip. (scikit-learn#7313)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7019. Supersedes #7022.
Also see discussion at #6990, #4164