[MRG] make appveyor fail on old builds when PR is updated#6365
Merged
ogrisel merged 1 commit intoscikit-learn:masterfrom Oct 13, 2016
Merged
[MRG] make appveyor fail on old builds when PR is updated#6365ogrisel merged 1 commit intoscikit-learn:masterfrom
ogrisel merged 1 commit intoscikit-learn:masterfrom
Conversation
Member
Author
|
I tested it on another project (python-appveyor-demo) and it worked as expected. |
Member
Author
|
Note that the issue with the "rolling builds" option in appveyor has been reported here: http://help.appveyor.com/discussions/problems/3936-rolling-builds-sometimes-cancel-erronously If it get fixed at the appveyor level this PR is obsolete. |
Member
|
@ogrisel what's the status on this? Looks like they didn't fix it yet and we should merge this, right? |
Member
Author
|
+1, let's merge. It's easy to revert if it causes problems. |
amueller
pushed a commit
to amueller/scikit-learn
that referenced
this pull request
Oct 14, 2016
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snippet taken from JuliaLang via: numpy/numpy#7247