Skip to content

[MRG] make appveyor fail on old builds when PR is updated#6365

Merged
ogrisel merged 1 commit intoscikit-learn:masterfrom
ogrisel:appveyor-fail-quick
Oct 13, 2016
Merged

[MRG] make appveyor fail on old builds when PR is updated#6365
ogrisel merged 1 commit intoscikit-learn:masterfrom
ogrisel:appveyor-fail-quick

Conversation

@ogrisel
Copy link
Copy Markdown
Member

@ogrisel ogrisel commented Feb 15, 2016

Snippet taken from JuliaLang via: numpy/numpy#7247

@ogrisel
Copy link
Copy Markdown
Member Author

ogrisel commented Feb 16, 2016

I tested it on another project (python-appveyor-demo) and it worked as expected.

@ogrisel ogrisel changed the title [MRG] make appveyor fail on old builds when PR is update [MRG] make appveyor fail on old builds when PR is updated Feb 18, 2016
@ogrisel
Copy link
Copy Markdown
Member Author

ogrisel commented Feb 18, 2016

Note that the issue with the "rolling builds" option in appveyor has been reported here:

http://help.appveyor.com/discussions/problems/3936-rolling-builds-sometimes-cancel-erronously

If it get fixed at the appveyor level this PR is obsolete.

@amueller
Copy link
Copy Markdown
Member

amueller commented Oct 8, 2016

@ogrisel what's the status on this? Looks like they didn't fix it yet and we should merge this, right?

@ogrisel
Copy link
Copy Markdown
Member Author

ogrisel commented Oct 13, 2016

+1, let's merge. It's easy to revert if it causes problems.

@ogrisel ogrisel merged commit cd0d46c into scikit-learn:master Oct 13, 2016
amueller pushed a commit to amueller/scikit-learn that referenced this pull request Oct 14, 2016
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants