[MRG] removed hard coded kernel params in Nystroem#6145
[MRG] removed hard coded kernel params in Nystroem#6145mth4saurabh wants to merge 1 commit intoscikit-learn:masterfrom
Conversation
mth4saurabh
commented
Jan 9, 2016
- Address PR added missing chi2 gamma parameter #5211
- Temporary solution for Issue Don't hard-code kernel parameters in Nystroem #5229
|
LGTM, thanks! Sorry for the slow reply :( |
|
Is it possible to add a test, @mth4saurabh? |
|
apart from lacking a test, I don't really see how this is backwards-compatible, @amueller. |
|
This should be backwards-compatible. The |
|
What should the test be? That the default behavior is |
|
maybe it would even be better to deprecate the three parameters here, as the behavior of them not being passed to callable is a bit weird and can lead to subtle bugs? |
|
How about if a callable was passed and any of the parameters was not None, we error? That might error on currently running code, but probably code that had a bug? |
|
See #9166. |
|
#9166 was merged. Closing. |