added missing chi2 gamma parameter#5211
added missing chi2 gamma parameter#5211nrhinehart wants to merge 1 commit intoscikit-learn:masterfrom
Conversation
There was a problem hiding this comment.
can you remove the exp_chi2? It's not in PAIRWISE_KERNEL_FUNCTIONS and I seem to have left it in there by mistake.
|
Travis is failing. |
|
Hm, the travis failure is because the default gamma for rbf is Maybe just add |
|
I would like to solve this issue. Where can I get some background about it? Also, is it a simple matter of removing the exp_chi2 line? |
|
The issue is mostly #5229 but can be worked around here as I explained above. Removing |
|
I fixed the problem with the hardcoded kernel parameter in the Nystroem approximation in PR #5316. In order to work with the changes addressed here, one would have to also add the gamma parameter to the kernel_default_param dictionary. This line is currently commented out in the PR. |
chi2 kernel gamma parameter was missing in
KERNEL_PARAMSdictionary, which caused the passedgammato be ignored when usingfilter_params = Trueinpairwise_kernels(X, filter_params = True, metric = 'chi2', gamma = gamma)