[MRG+1] minor edits to multiclass documentation by pieteradejong · Pull Request #5837 · scikit-learn/scikit-learn

pieteradejong · 2015-11-16T19:19:33Z

minor changes to become familiar with the process

pieteradejong · 2015-11-16T19:30:48Z

[MRG] ready to be merged, please review

TomDLT · 2015-11-26T12:53:33Z

doc/modules/multiclass.rst

I would keep the in.

not sure. http://english.stackexchange.com/questions/95929/consists-of-vs-consists-in-different-meanings-of-the-verb-or-the-same-mea http://english.stackexchange.com/questions/61600/consist-in-vs-consist-of

I think it is telling that the first hits for "consists in" are of stackexchange discussing the usage of the phrase.

I think "consists of" is better...

TomDLT · 2015-11-26T12:56:17Z

Nitpicks, but this looks good to me.
Thanks @pieteradejong

amueller · 2015-12-09T00:42:50Z

doc/modules/multiclass.rst

nice catch ^^

amueller · 2015-12-09T00:43:56Z

please squash. LGTM apart from one comma, but I'm not a native speaker.

pieteradejong · 2016-01-14T06:29:03Z

ready to merge?

devashishd12 · 2016-01-14T06:53:46Z

doc/modules/multiclass.rst

~~Shouldn't this be problems are restricted?~~

TomDLT · 2016-01-14T10:00:44Z

~~After final comments are addressed, could you also squash and rebase ?~~

amueller · 2016-01-15T20:17:30Z

doc/modules/multiclass.rst

I would say "which only considers binary classification". Currently the sentence is a bit awkward (what does "where" refer to?)

amueller · 2016-01-15T20:18:21Z

otherwise lgtm, please squash.

nelson-liu · 2016-09-29T04:12:17Z

now that we can rebase and squash in github, shall we do that here?

TomDLT · 2016-09-29T09:41:52Z

now that we can rebase and squash in github, shall we do that here?

There is no conflicts with master, so no need to rebase or squash.

jnothman · 2016-09-29T10:31:26Z

There is still an open comment, though...

On 29 September 2016 at 19:41, Tom Dupré la Tour notifications@github.com
wrote:

now that we can rebase and squash in github, shall we do that here?

There is no conflicts with master, so no need to rebase or squash.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#5837 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEz66FFjv6tb26bn8hrB3bu4s8p2Nw1ks5qu4fhgaJpZM4GjPuL
.

nelson-liu · 2016-09-29T13:04:16Z

Ah apologies didn't see the open comment, but only @amueller and @TomDLT asking for a squash (I presume this is before the github feature )

amueller · 2016-09-29T14:00:32Z

Eh, let's merge and fix in master? The sentence was awkward before.

jnothman · 2016-09-30T02:52:56Z

Done, thanks @pieteradejong

* minor edits to multiclass documentation * minor text formatting and language modifications * minor word changes, sentence clarifications * attempt to fix ci test * restored previous paragraph * minor grammatical correction * minor grammar fixes

minor edits to multiclass documentation

fa2a218

amueller mentioned this pull request Nov 16, 2015

[MRG] docs: dataset transformation #5841

Closed

minor text formatting and language modifications

8745c93

pieteradejong changed the title ~~initial pull req: minor edits to multiclass documentation~~ [MRG] minor edits to multiclass documentation Nov 16, 2015

TomDLT reviewed Nov 26, 2015
View reviewed changes

TomDLT changed the title ~~[MRG] minor edits to multiclass documentation~~ [MRG+1] minor edits to multiclass documentation Nov 26, 2015

Pieter de Jong and others added 3 commits November 30, 2015 15:38

minor word changes, sentence clarifications

86cf067

attempt to fix ci test

11cd0db

restored previous paragraph

f69494a

amueller reviewed Dec 9, 2015
View reviewed changes

doc/modules/multiclass.rst Outdated

Copy link
Copy Markdown

Member

amueller Dec 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch ^^

amueller added the Waiting for Reviewer label Dec 10, 2015

minor grammatical correction

13d3bd6

devashishd12 reviewed Jan 14, 2016
View reviewed changes

doc/modules/multiclass.rst

Copy link
Copy Markdown

Contributor

devashishd12 Jan 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~~Shouldn't this be problems are restricted?~~

minor grammar fixes

d79d6d0

amueller reviewed Jan 15, 2016
View reviewed changes

nelson-liu mentioned this pull request Sep 29, 2016

[MRG+2] DOC add info to conventions for multi-label fitting #7519

Merged

jnothman merged commit 8442eea into scikit-learn:master Sep 30, 2016

Uh oh!

Conversation

pieteradejong commented Nov 16, 2015

Uh oh!

pieteradejong commented Nov 16, 2015

Uh oh!

TomDLT Nov 26, 2015

Choose a reason for hiding this comment

Uh oh!

pieteradejong Nov 30, 2015

Choose a reason for hiding this comment

Uh oh!

amueller Dec 9, 2015

Choose a reason for hiding this comment

Uh oh!

amueller Dec 9, 2015

Choose a reason for hiding this comment

Uh oh!

TomDLT commented Nov 26, 2015

Uh oh!

amueller Dec 9, 2015

Choose a reason for hiding this comment

Uh oh!

amueller commented Dec 9, 2015

Uh oh!

pieteradejong commented Jan 14, 2016

Uh oh!

devashishd12 Jan 14, 2016

Choose a reason for hiding this comment

Uh oh!

TomDLT commented Jan 14, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amueller Jan 15, 2016

Choose a reason for hiding this comment

Uh oh!

amueller commented Jan 15, 2016

Uh oh!

nelson-liu commented Sep 29, 2016

Uh oh!

TomDLT commented Sep 29, 2016

Uh oh!

jnothman commented Sep 29, 2016

Uh oh!

nelson-liu commented Sep 29, 2016

Uh oh!

amueller commented Sep 29, 2016

Uh oh!

jnothman commented Sep 30, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

TomDLT commented Jan 14, 2016 •

edited

Loading