[MRG + 1] Remove deprecated stuff from SVM#5469
Merged
glouppe merged 1 commit intoscikit-learn:masterfrom Oct 21, 2015
Merged
Conversation
20 tasks
2cb71c1 to
a42ec1b
Compare
Member
|
Sorry, the |
Member
|
apart from removing the ovr stuff, LGTM. |
Member
Author
|
done thanks for the review :) (Tests are running on my local machine and travis... I'll ping once they pass) |
MAINT Remove support for gamma == 0.0 MAINT Remove support for uppercase values for loss and penalty
Member
|
LGTM. |
Member
Author
|
@glouppe review pl? :) |
Contributor
|
I am no expert of this part of the codebase, but given the FIXME messages left by the original maintainer, I believe your changes are fine. At least I dont see anything obviously wrong. And Travis is happy. Merging. |
glouppe
added a commit
that referenced
this pull request
Oct 21, 2015
[MRG + 1] Remove deprecated stuff from SVM
Member
Author
|
Thanks for the merge!
Would it still be fine if I was the one who left those messages? :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue at #5434
gamma = 0.0and setgammato1 / n_featureswhen'auto'is used...svm/tests/test_svm.py, uppercase support in_fit_liblinearfunction insvm/base.py, Refer [MRG+1] Fix brokenL1deprecations and svm scale C example. #4261 and Broken plot_svm_scale_c.py example #4260 also svm/classes.py L192)