[MRG + 1] Removed deprecated stuff in 0.18#5451
[MRG + 1] Removed deprecated stuff in 0.18#5451amueller merged 2 commits intoscikit-learn:masterfrom
Conversation
fe39f7e to
e584345
Compare
|
Ignore the circle CI report, this is unrelated to this PR. |
|
travis fails though, because of some test of the deprecation in enet. |
There was a problem hiding this comment.
This cleanup makes me unreasonably happy!
There was a problem hiding this comment.
cdba563 to
07ca31f
Compare
|
-500 lines 🍻 |
|
@amueller @GaelVaroquaux Could you take a look at this since travis seems to be happy? |
07ca31f to
a5b6c52
Compare
|
Looks good to me, but we should wait for CircleCI to be back up, to be sure examples are still fine. |
There was a problem hiding this comment.
this part needs to be undone. It should be 0.19. Please change the error accordingly. Why is auto in this list twice?
There was a problem hiding this comment.
Ok, I added it back without the duplicate.
|
circleci should no longer be triggered on PRs. It's supposed to be triggered only after merge to master: https://github.com/scikit-learn/scikit-learn/blob/master/circle.yml#L31 If it does not, it might be that I don't understand how to interpret the documentation of this feature. |
sklearn/utils/class_weight.py
Outdated
There was a problem hiding this comment.
yeah this should also be 0.19 I guess.
|
looks great apart from my two comments. sorry for the confusion, I think that was me. I'm bad at counting. |
There was a problem hiding this comment.
this needs to go back in, too.
There was a problem hiding this comment.
I cannot see this: the tests need to be restored to check that the class_weight='subsample' option is still supported (despite being deprecated).
8aa4a7f to
d63b33f
Compare
|
LGTM |
|
This comment #5451 (diff) was not addressed. |
sklearn/ensemble/forest.py
Outdated
There was a problem hiding this comment.
"... is deprecated in 0.17 and will be removed in 0.19..."
It's important to be explicit with the version number when it was deprecated to make it easier to detect violations to our deprecation policy.
|
Added the 0.17 milestone because we need to backport the fix for the incorrect deprecation warning messages to the 0.17.0 release. |
|
@zermelozf once my last comments are addressed, +1 for merge as well. You don't need to wait for appveyor. I am afraid it won't catch up this week... |
d63b33f to
62633f7
Compare
[MRG + 1] Removed deprecated stuff in 0.18
|
@ogrisel you wanna backport? |
|
did the backport myself |
|
@zermelozf is your handle refering to https://en.wikipedia.org/wiki/Zermelo%E2%80%93Fraenkel_set_theory ? I guess there is an extra Z. |
* commit '0.17b1-14-g4e6829c': Corrected macro ROC in example plot_roc BF: FIX OvR decision_function_shape in SVC Fix fit_transform, stability issue and scale issue in PLS FIX class_weight in LogisticRegression and LogisticRegressionCV FIX MaxAbsScaler on sparse matrices with 1 row Deprecate residues_ in LinearRegression Addressed comments on PR scikit-learn#5451 MAINT Removed deprecated stuff. MAINT disable circle ci on 0.17.X MAINT: deprecation warns from StandardScaler std_ FIX: remove shuffling in LabelKFold FIX skip LDA deprecation test on python3.3 that has no reload. Fix broken examples using RandomTreeEmbeddings MAINT Use the full listing of the rackspace wheelhouse for appveyor Conflicts: sklearn/externals/joblib/format_stack.py -- removed
* dfsg: Corrected macro ROC in example plot_roc BF: FIX OvR decision_function_shape in SVC Fix fit_transform, stability issue and scale issue in PLS FIX class_weight in LogisticRegression and LogisticRegressionCV FIX MaxAbsScaler on sparse matrices with 1 row Deprecate residues_ in LinearRegression Addressed comments on PR scikit-learn#5451 MAINT Removed deprecated stuff. MAINT disable circle ci on 0.17.X MAINT: deprecation warns from StandardScaler std_ FIX: remove shuffling in LabelKFold FIX skip LDA deprecation test on python3.3 that has no reload. Fix broken examples using RandomTreeEmbeddings MAINT Use the full listing of the rackspace wheelhouse for appveyor
* commit '0.17b1-14-g4e6829c': Corrected macro ROC in example plot_roc BF: FIX OvR decision_function_shape in SVC Fix fit_transform, stability issue and scale issue in PLS FIX class_weight in LogisticRegression and LogisticRegressionCV FIX MaxAbsScaler on sparse matrices with 1 row Deprecate residues_ in LinearRegression Addressed comments on PR scikit-learn#5451 MAINT Removed deprecated stuff. MAINT disable circle ci on 0.17.X MAINT: deprecation warns from StandardScaler std_ FIX: remove shuffling in LabelKFold FIX skip LDA deprecation test on python3.3 that has no reload. Fix broken examples using RandomTreeEmbeddings MAINT Use the full listing of the rackspace wheelhouse for appveyor
Contributes to #5434.
Removes the following deprecated code:
pooling_funcin transform ofAgglomerationTransformin filecluster/_feature_agglomeration.pyrandom_stateparameter incluster/dbscan_.pyn_componentsincluster/hierarchical.pymax_iterationsincluster/mean_shift_.pyclass_weight="subsample"inutils/class_weight.pyallow_listsandallow_nd/ insklearn/cross_validation.py`.estimator_paramsinsklearn/feature_selection/rfe.pythreshold_in 'OutlierDetectionMixinat filesklearn/covariance/outlier_detection.py`precompute="auto"insklearn/linear_models/coordinate_descent.pyandsklearn/utils/class_weight.pythreshinsklearn/mixture/dpgmm.pyandsklearn/mixture/gmm.py.sklearn/multiclass.py.sklearn/neighbors.sklearn/preprocessing.sklearn/utils/classs_weight.py