Closed
Conversation
Member
|
I think we should do something about it. The pb has been raised in the past and solved in GridSearchCV with when X is sparse. shall all cross-val objects should be able to return indices rather than mask? loo = LeaveOneOut(n, mask=False) ??? |
Member
|
@agramfort +1 |
Member
|
+1 on Alex's proposal, but I wonder if we can have a more explicit argument. Something like 'indices=True' :). G |
Member
|
feed back welcome |
Member
|
@agramfort: looks good in general. Joseph, would that solve your needs? Also, the documentation should be updated to mention this, in a way similar to what Joseph had originally proposed. |
Member
|
done in : #54 Joseph? happy with that? |
Member
|
I assume yes... |
adam2392
added a commit
to PSSF23/scikit-learn-stream
that referenced
this pull request
Aug 11, 2023
Merging latest changes from sklearn main #### What does this implement/fix? Explain your changes. #### Any other comments? <!-- Please be aware that we are a loose team of volunteers so patience is necessary; assistance handling other issues is very welcome. We value all user contributions, no matter how minor they are. If we are slow to review, either the pull request needs some benchmarking, tinkering, convincing, etc. or more likely the reviewers are simply busy. In either case, we ask for your understanding during the review process. For more information, see our FAQ on this topic: http://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention. Thanks for contributing! --> --------- Signed-off-by: Adam Li <adam2392@gmail.com>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.